Video Capture: extract storage info from pixel format in VideoCaptureFormat.

media/capture/screen_capture_device_core.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/screen_capture_device_core.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 24 matching lines @@
 
   if (params.requested_format.frame_rate <= 0) {
     std::string error_msg("Invalid frame_rate: ");
     error_msg += base::DoubleToString(params.requested_format.frame_rate);
     DVLOG(1) << error_msg;
     client->OnError(error_msg);
     return;
   }
 
   if (params.requested_format.pixel_format != PIXEL_FORMAT_I420 &&
-      params.requested_format.pixel_format != PIXEL_FORMAT_TEXTURE) {
+      params.requested_format.pixel_storage != PIXEL_STORAGE_TEXTURE) {

[miu, 2015/06/23 22:58:15]

I think the logical-AND should be a logical-OR now, right?

[mcasas, 2015/06/23 23:24:43]

Done.

[miu, 2015/06/23 23:35:55]

Oh wait.  I might have misled you here.  I think there are only two supported
format+storage combos: I420+STORAGE_CPU and ARGB+STORAGE_TEXTURE.  The logic
should probably be:

  if (!(params.requested_format.pixel_format == PIXEL_FORMAT_I420 &&
        params.requested_format.pixel_storage == PIXEL_STORAGE_CPU) &&
      !(params.requested_format.pixel_format == PIXEL_FORMAT_ARGB &&
        params.requested_format.pixel_storage == PIXEL_STORAGE_TEXTURE)) {
    ...do unsupported error...
    return;
  }

[mcasas, 2015/06/24 00:16:39]

Done.

     std::string error_msg = base::StringPrintf(
         "unsupported format: %d", params.requested_format.pixel_format);

[miu, 2015/06/23 22:58:15]

Please update error message to include storage texture, as well.

[mcasas, 2015/06/23 23:24:43]

Done.

     DVLOG(1) << error_msg;
     client->OnError(error_msg);
     return;
   }
 
   if (params.requested_format.frame_size.IsEmpty()) {
     std::string error_msg =
         "invalid frame size: " + params.requested_format.frame_size.ToString();
     DVLOG(1) << error_msg;
     client->OnError(error_msg);
@@ skipping 71 matching lines @@
     return;
 
   if (oracle_proxy_.get())
     oracle_proxy_->ReportError(reason);
 
   StopAndDeAllocate();
   TransitionStateTo(kError);
 }
 
 }  // namespace media