Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/IceTargetLowering.h

Issue 1179313004: Fix a bug that would cause subzero to fail when --threads=0. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses codereview comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 4d9598a2448b917379a42116f9665307e8034700..1f2f274e534a136df0fbed9ad355bdf9be28f565 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -380,16 +380,18 @@ public:
static std::unique_ptr<TargetDataLowering> createLowering(GlobalContext *Ctx);
virtual ~TargetDataLowering();
- virtual void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) = 0;
- virtual void lowerConstants() = 0;
+ virtual void lowerGlobals(const VariableDeclarationList &Vars,
+ const IceString &SectionSuffix) = 0;
+ virtual void lowerConstants(const IceString &SectionSuffix) = 0;
protected:
- void emitGlobal(const VariableDeclaration &Var);
+ void emitGlobal(const VariableDeclaration &Var,
+ const IceString &SectionSuffix);
// For now, we assume .long is the right directive for emitting 4 byte
// emit global relocations. However, LLVM MIPS usually uses .4byte instead.
// Perhaps there is some difference when the location is unaligned.
- const char *getEmit32Directive() { return ".long"; }
+ static const char *getEmit32Directive() { return ".long"; }
explicit TargetDataLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
GlobalContext *Ctx;

Powered by Google App Engine
This is Rietveld 408576698