Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 1179313004: Fix a bug that would cause subzero to fail when --threads=0. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses codereview comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 0b46e1bde9201aa44f389b900e144beee94f9549..6ba687779dac3a9f3315afd8fd2520d5678b02f5 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -587,8 +587,9 @@ public:
return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
}
- void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
- void lowerConstants() override;
+ void lowerGlobals(const VariableDeclarationList &Vars,
+ const IceString &SectionSuffix) override;
+ void lowerConstants(const IceString &SectionSuffix) override;
Jim Stichnoth 2015/06/17 16:04:56 I don't see the SectionSuffix argument actually us
John 2015/06/17 18:18:35 This was just for future proofing -- and also to k
protected:
explicit TargetDataX8632(GlobalContext *Ctx);

Powered by Google App Engine
This is Rietveld 408576698