Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 1179273003: When using git-rebase-update, pass -n to git commit. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When using git-rebase-update, pass --no-verify to git commit. Otherwise this creates a mess for WIP branches that do not pass the git pre-commit hook. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295742

Patch Set 1 #

Patch Set 2 : s/-n/--no-verify/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_common.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
M-A Ruel
5 years, 6 months ago (2015-06-18 18:35:26 UTC) #1
iannucci
lgtm
5 years, 6 months ago (2015-06-18 18:43:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179273003/1
5 years, 6 months ago (2015-06-18 18:44:07 UTC) #4
iannucci
Though can you grep for other uses of this function too? And maybe call out ...
5 years, 6 months ago (2015-06-18 18:44:30 UTC) #5
M-A Ruel
On 2015/06/18 18:44:30, iannucci wrote: > Though can you grep for other uses of this ...
5 years, 6 months ago (2015-06-18 18:46:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179273003/20001
5 years, 6 months ago (2015-06-18 18:46:53 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 18:49:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295742

Powered by Google App Engine
This is Rietveld 408576698