Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 11791043: Benchmark to characterize main thread usage during load (Closed)

Created:
7 years, 11 months ago by nduca
Modified:
7 years, 11 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org, eseidel, haraken1
Visibility:
Public.

Description

Benchmark to characterize main thread usage during load This uses inspector timeline and telemetry to get an estimate of time consumption during page load. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176132

Patch Set 1 #

Patch Set 2 : much better #

Patch Set 3 : self_time #

Patch Set 4 : ready for handoff #

Patch Set 5 : this_could_land #

Total comments: 1

Patch Set 6 : nitfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A tools/perf/perf_tools/loading_benchmark.py View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
A tools/perf/perf_tools/loading_benchmark_unittest.py View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nduca
just a rough sketch. I think the data is wrong but the approach is roughly ...
7 years, 11 months ago (2013-01-08 06:35:21 UTC) #1
nduca
Ah, the data set is funky because some inspector events dont actually have end times.
7 years, 11 months ago (2013-01-08 07:00:24 UTC) #2
nduca
patchset 3 depends on https://codereview.chromium.org/11779041/, which should land tomorrow to clean up csv output logic.
7 years, 11 months ago (2013-01-08 13:12:42 UTC) #3
nduca
Eric, in theory this runs ToT. Maybe you can pick it up from here and ...
7 years, 11 months ago (2013-01-09 21:38:47 UTC) #4
abarth-chromium
On 2013/01/09 21:38:47, nduca wrote: > Eric, in theory this runs ToT. Maybe you can ...
7 years, 11 months ago (2013-01-09 21:40:40 UTC) #5
nduca
Needs chrome >= r175886
7 years, 11 months ago (2013-01-09 21:44:01 UTC) #6
abarth-chromium
This works great! LGTM, but I'm probably not an owner.
7 years, 11 months ago (2013-01-10 01:51:29 UTC) #7
nduca
Hows this as a landable benchmark? I've fixed most of the issues. An open is ...
7 years, 11 months ago (2013-01-10 10:42:08 UTC) #8
tonyg
lgtm with nit This is awesome! https://codereview.chromium.org/11791043/diff/8002/tools/perf/perf_tools/loading_benchmark.py File tools/perf/perf_tools/loading_benchmark.py (right): https://codereview.chromium.org/11791043/diff/8002/tools/perf/perf_tools/loading_benchmark.py#newcode26 tools/perf/perf_tools/loading_benchmark.py:26: if e.name not ...
7 years, 11 months ago (2013-01-10 18:53:05 UTC) #9
nduca
> Use collections.defaultdict(list) to clean this up. Holy crap thats cool. I learned something new ...
7 years, 11 months ago (2013-01-10 18:55:32 UTC) #10
nduca
(note to sheriffs: notry=true because none of this code is live on the main waterfall)
7 years, 11 months ago (2013-01-10 19:39:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11791043/15003
7 years, 11 months ago (2013-01-10 19:39:59 UTC) #12
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 19:43:07 UTC) #13
Message was sent while issue was closed.
Change committed as 176132

Powered by Google App Engine
This is Rietveld 408576698