mac: New asset for the tabstrip border, tweak drawing.

mac: New asset for the tabstrip border, tweak drawning.

Paint the tab outline, new tab button outline, and the tabstrip border
at 0.65 opacity in non-focused windows, like image_button_cell does already.
Also change inactive tabs to not paint on top of the tabstrip.

BUG=166403, 52468
TEST=look at tab strip, it now has a white line below the grey line
again. With themes, the theme color shines through the separator line
again.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175402

[Nico, 2013-01-07 20:33:55]

sail@ might be out?

[Robert Sesek, 2013-01-07 20:56:16]

LGTM

[Nico, 2013-01-07 21:56:17]

Please take another look, this changed a bit on feedback from sgabriel.

Do we have some file with common ui constants? The alpha factor is now in
several places. Not terrible, but…

[Nico, 2013-01-07 21:57:21]

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
chrome/browser/ui/cocoa/tabs/tab_view.mm:426: alpha,
(I measured that this doesn't regress throbber performance.)

[Robert Sesek, 2013-01-07 22:08:04]

On 2013/01/07 21:56:17, Nico wrote:
> Please take another look, this changed a bit on feedback from sgabriel.
> 
> Do we have some file with common ui constants? The alpha factor is now in
> several places. Not terrible, but…

Not that I'm aware. Does this fit in the ThemeService? If not, perhaps at least
unify it for c/b/u/c/tabs/ in tab_view.h.

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
File chrome/browser/ui/cocoa/image_button_cell.mm (left):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
chrome/browser/ui/cocoa/image_button_cell.mm:23: } // namespace
Why this?

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
chrome/browser/ui/cocoa/tabs/tab_view.mm:413: bool focused = [[self window]
isKeyWindow] || [[self window] isMainWindow];
BOOL

[Nico, 2013-01-07 22:20:15]

Thanks, moved the constant to tab_view.h.

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
File chrome/browser/ui/cocoa/image_button_cell.mm (left):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
chrome/browser/ui/cocoa/image_button_cell.mm:23: } // namespace
On 2013/01/07 22:08:04, rsesek wrote:
> Why this?

const has implicit internal linkage, so the namespace is not necessary. I can
revert it if you want, it just makes the file a bit shorter.

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/ta...
chrome/browser/ui/cocoa/tabs/tab_view.mm:413: bool focused = [[self window]
isKeyWindow] || [[self window] isMainWindow];
On 2013/01/07 22:08:04, rsesek wrote:
> BOOL

DONE

[Robert Sesek, 2013-01-07 22:24:27]

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
File chrome/browser/ui/cocoa/image_button_cell.mm (left):

https://codereview.chromium.org/11791030/diff/4003/chrome/browser/ui/cocoa/im...
chrome/browser/ui/cocoa/image_button_cell.mm:23: } // namespace
On 2013/01/07 22:20:15, Nico wrote:
> On 2013/01/07 22:08:04, rsesek wrote:
> > Why this?
> 
> const has implicit internal linkage, so the namespace is not necessary. I can
> revert it if you want, it just makes the file a bit shorter.

Ah differences from C are always so fun. I think the namespace{} is the norm in
.cc files for constants, even if it isn't strictly required. Won't press it
either way, though.

[Robert Sesek, 2013-01-07 22:24:34]

(still LGTM)

[sail, 2013-01-07 22:45:58]

LGTM to me too!