mac: New asset for the tabstrip border, tweak drawing.

chrome/browser/ui/cocoa/image_button_cell.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
 
 #include "base/logging.h"
 #import "chrome/browser/themes/theme_service.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 
-namespace {
-
 // Adjust the overlay position relative to the top right of the button image.
 const CGFloat kOverlayOffsetX = -3;
 const CGFloat kOverlayOffsetY = 5;
 
 // When the window doesn't have focus then we want to draw the button with a
 // slightly lighter color. We do this by just reducing the alpha.
 const CGFloat kImageNoFocusAlpha = 0.65;
 
-} // namespace

[Robert Sesek, 2013/01/07 22:08:04]

Why this?

[Nico, 2013/01/07 22:20:15]

const has implicit internal linkage, so the namespace is not necessary. I can
revert it if you want, it just makes the file a bit shorter.

[Robert Sesek, 2013/01/07 22:24:28]

Ah differences from C are always so fun. I think the namespace{} is the norm in
.cc files for constants, even if it isn't strictly required. Won't press it
either way, though.

-
 @interface ImageButtonCell (Private)
 - (void)sharedInit;
 - (image_button_cell::ButtonState)currentButtonState;
 - (NSImage*)imageForID:(NSInteger)imageID
            controlView:(NSView*)controlView;
 @end
 
 @implementation ImageButtonCell
 
 @synthesize overlayImageID = overlayImageID_;
@@ skipping 165 matching lines @@
 
 - (void)mouseEntered:(NSEvent*)theEvent {
   [self setIsMouseInside:YES];
 }
 
 - (void)mouseExited:(NSEvent*)theEvent {
   [self setIsMouseInside:NO];
 }
 
 @end