Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1178893002: Introduce LookupIterator::PropertyOrElement which converts name to index if possible. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce LookupIterator::PropertyOrElement which converts name to index if possible. BUG=v8:4137 LOG=n Committed: https://crrev.com/2ea4f01f704f4453926b3376f8c5b098984dc8f8 Cr-Commit-Position: refs/heads/master@{#29004}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -91 lines) Patch
M src/api-natives.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/lookup.h View 6 chunks +29 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 7 chunks +12 lines, -29 lines 0 comments Download
M src/objects-inl.h View 1 2 3 2 chunks +6 lines, -13 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 4 4 chunks +16 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-11 13:19:44 UTC) #2
Jakob Kummerow
LGTM!
5 years, 6 months ago (2015-06-11 15:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178893002/70001
5 years, 6 months ago (2015-06-12 16:04:06 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 6 months ago (2015-06-12 16:30:09 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/2ea4f01f704f4453926b3376f8c5b098984dc8f8 Cr-Commit-Position: refs/heads/master@{#29004}
5 years, 6 months ago (2015-06-12 16:30:30 UTC) #8
Michael Achenbach
This fixes the layout test (which blocked the roll), but now blocks the roll in ...
5 years, 6 months ago (2015-06-13 07:18:51 UTC) #10
Toon Verwaest
Looking into it.
5 years, 6 months ago (2015-06-13 09:57:45 UTC) #11
Toon Verwaest
5 years, 6 months ago (2015-06-13 10:36:06 UTC) #12
Message was sent while issue was closed.
The roll was blocked since I added a correctness DCHECK to ensure we never try
to look up indexed properties as named properties. Apparently the *RealNamed*
API methods only have named variants, but were always used by the embedder to
find elements as well. We'd never find them though, since we wouldn't even look
there.

I'm submitting a CL that ensures we also look for elements now:
https://codereview.chromium.org/1177383004/

I guess for all named API functions we should assume they are used similar to
o["name"] where name could also be a number... At least we should make it
uniform between embedder and V8. This matches us up with their expectations for
now...

Powered by Google App Engine
This is Rietveld 408576698