src/runtime/runtime-debug.cc - Issue 1178893002: Introduce LookupIterator::PropertyOrElement which converts name to index if possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 1178893002: Introduce LookupIterator::PropertyOrElement which converts name to index if possible. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 5ae797986eefdb93bd0897f7bd2990d30bf09ef1..e01dd8797d5fb26ca7f7327e492d62f6b890b784 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -306,6 +306,8 @@ RUNTIME_FUNCTION(Runtime_DebugGetPropertyDetails) {

// Check if the name is trivially convertible to an index and get the element

// if so.

uint32_t index;

+ // TODO(verwaest): Make sure DebugGetProperty can handle arrays, and remove

+ // this special case.

if (name->AsArrayIndex(&index)) {

Handle<FixedArray> details = isolate->factory()->NewFixedArray(2);

Handle<Object> element_or_char;

« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »