Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 117883002: Removing use of AlertDialog.Builder.setOnDismissListener from InputDialogContainer (Closed)

Created:
7 years ago by keishi
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing use of AlertDialog.Builder.setOnDismissListener from InputDialogContainer AlertDialog.Builder.setOnDismissListener exists only in API 17 and above. BUG=329327 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243294

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
keishi
7 years ago (2013-12-18 02:32:37 UTC) #1
jdduke (slow)
lgtm with nit. https://codereview.chromium.org/117883002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java File content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java (right): https://codereview.chromium.org/117883002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java#newcode32 content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java:32: * Opens the approprate date/time picker ...
7 years ago (2013-12-18 15:48:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/117883002/20001
6 years, 11 months ago (2014-01-06 03:01:14 UTC) #3
keishi
https://codereview.chromium.org/117883002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java File content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java (right): https://codereview.chromium.org/117883002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java#newcode32 content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java:32: * Opens the approprate date/time picker dialog for tthe ...
6 years, 11 months ago (2014-01-06 03:01:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241749
6 years, 11 months ago (2014-01-06 06:03:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/117883002/20001
6 years, 11 months ago (2014-01-06 06:08:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241792
6 years, 11 months ago (2014-01-06 11:28:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/117883002/20001
6 years, 11 months ago (2014-01-07 09:57:01 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 15:16:47 UTC) #9
Message was sent while issue was closed. 
Change committed as 243294

Powered by Google App Engine
This is Rietveld 408576698