Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java

Issue 117883002: Removing use of AlertDialog.Builder.setOnDismissListener from InputDialogContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java b/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java
index 1a0881eef721db96bb89ea2ef84c6285983c41f5..0f697754480d97fee05f4c2ee0ef4911841242b0 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java
@@ -28,6 +28,9 @@ import java.util.GregorianCalendar;
import java.util.TimeZone;
import java.util.concurrent.TimeUnit;
+/**
+ * Opens the approprate date/time picker dialog for the given dialog type.
+ */
public class InputDialogContainer {
interface InputActionDelegate {
@@ -169,15 +172,6 @@ public class InputDialogContainer {
mDialog = new AlertDialog.Builder(mContext)
.setTitle(dialogTitleId)
.setView(suggestionListView)
- .setOnDismissListener(new DialogInterface.OnDismissListener() {
- @Override
- public void onDismiss(DialogInterface dialog) {
- if (mDialog == dialog && !mDialogAlreadyDismissed) {
- mDialogAlreadyDismissed = true;
- mInputActionDelegate.cancelDateTimeDialog();
- }
- }
- })
.setNegativeButton(mContext.getText(android.R.string.cancel),
new DialogInterface.OnClickListener() {
@Override
@@ -187,6 +181,15 @@ public class InputDialogContainer {
})
.create();
+ mDialog.setOnDismissListener(new DialogInterface.OnDismissListener() {
+ @Override
+ public void onDismiss(DialogInterface dialog) {
+ if (mDialog == dialog && !mDialogAlreadyDismissed) {
+ mDialogAlreadyDismissed = true;
+ mInputActionDelegate.cancelDateTimeDialog();
+ }
+ }
+ });
mDialogAlreadyDismissed = false;
mDialog.show();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698