Issue 1178723010: Make the popup menu work again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178723010: Make the popup menu work again. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make the popup menu work again. This removes the requirement that things with the same type things have unique keys. Now, anything without a key is assumed to be interchangeable. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ba8bb3dc79b44d82cb0a20b24d0eae753b136a8c

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -41 lines)			Patch
M	sky/examples/stocks2/lib/stock_home.dart	View	1 2	1 chunk	+4 lines, -10 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_row.dart	View	1 2	1 chunk	+19 lines, -10 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_settings.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/drawer_header.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/fixed_height_scrollable.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	1	6 chunks	+10 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Hixie

5 years, 6 months ago (2015-06-17 22:10:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
ba8bb3dc79b44d82cb0a20b24d0eae753b136a8c (presubmit successful).