Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: sky/sdk/lib/widgets/fixed_height_scrollable.dart

Issue 1178723010: Make the popup menu work again. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/drawer_header.dart ('k') | sky/sdk/lib/widgets/popup_menu.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/fixed_height_scrollable.dart
diff --git a/sky/sdk/lib/widgets/fixed_height_scrollable.dart b/sky/sdk/lib/widgets/fixed_height_scrollable.dart
index 4905336d82cd906b42bd1ff958c938b2f2fa85cc..3ae0d04746d5a377333667c76ad633b4eba38e3d 100644
--- a/sky/sdk/lib/widgets/fixed_height_scrollable.dart
+++ b/sky/sdk/lib/widgets/fixed_height_scrollable.dart
@@ -68,12 +68,15 @@ abstract class FixedHeightScrollable extends Scrollable {
}
}
+ List<Widget> items = buildItems(itemShowIndex, itemShowCount);
+ assert(items.every((item) => item.key != null));
+
return new SizeObserver(
callback: _handleSizeChanged,
child: new ClipRect(
child: new Transform(
transform: transform,
- child: new Block(buildItems(itemShowIndex, itemShowCount))
+ child: new Block(items)
)
)
);
« no previous file with comments | « sky/sdk/lib/widgets/drawer_header.dart ('k') | sky/sdk/lib/widgets/popup_menu.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698