Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 11787006: Avoid going through WebWidget::composite to composite a RenderWidget (Closed)

Created:
7 years, 11 months ago by jamesr
Modified:
7 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, enne (OOO)
Visibility:
Public.

Description

Avoid going through WebWidget::composite to composite a RenderWidget When a content::RenderWidget is using accelerated compositing, the compositing is driven either by a WebLayerTreeView owned by the RenderWidget or a PepperWidget if the RenderWidget is actually a RenderWidgetFullscreenPepper. Neither case involves WebKit, so this avoids calling WebWidget::composite in favor of directly calling in to the appropriate compositing system. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178746

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M content/renderer/render_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
This depends on https://codereview.chromium.org/11575049/. Once both land, the WebKit::WebWidget::composite() API will go away completely. Manually ...
7 years, 11 months ago (2013-01-04 22:20:10 UTC) #1
brettw
lgtm https://codereview.chromium.org/11787006/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): https://codereview.chromium.org/11787006/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#newcode505 content/renderer/render_widget_fullscreen_pepper.cc:505: void RenderWidgetFullscreenPepper::Composite() { Can you put a comment ...
7 years, 11 months ago (2013-01-04 22:22:25 UTC) #2
nduca
This is awesome. Also, I think we should totally use the comment text suggested by ...
7 years, 11 months ago (2013-01-05 00:32:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11787006/4001
7 years, 11 months ago (2013-01-25 01:49:34 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 04:38:16 UTC) #5
Message was sent while issue was closed.
Change committed as 178746

Powered by Google App Engine
This is Rietveld 408576698