Get drag and drop working on Win Ash.

Get drag and drop working on Win Ash.

BUG=154081
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175494

[jam, 2013-01-04 22:23:01]

https://codereview.chromium.org/11787005/diff/1/ui/base/dragdrop/drag_utils_w...
File ui/base/dragdrop/drag_utils_win.cc (right):

https://codereview.chromium.org/11787005/diff/1/ui/base/dragdrop/drag_utils_w...
ui/base/dragdrop/drag_utils_win.cc:75: // violation.
Basically this code block is doing thw ork for both non-ash and ash. I'm not
sure how to fix this given that this code is in ui/base/dragdrop. Other code in
ui/base depends on this (like ui/base/events/event.h) so moving it out of
ui/base doesn't seem to be an option.

I could easily plumb in the NativeView or NativeWindow associated with a drag
from all the callsites. But unless I can tell whether this is ash or not, then I
can't do only one part of this function. Really we don't even need to use
OSExchangeDataProviderWin on win ash at all; but again at the creation site
(which happens in ui/ sometimes) it would need to know ash vs non ash. The other
alternative is to plumb yet another delegate interface to chrome, although that
feels like having the layer know the same knowledge but wrapped differently.

wdyt?

[jam, 2013-01-05 01:21:48]

btw I can't tell why DragDropControllerTest fails on the trybot. it passes
locally.

[jam, 2013-01-07 20:35:25]

+sky since he added the DCHECK in drag_drop_controller_unittest.cc that's
failing.

Scott: I couldn't reproduce this before, but now that I remote desktop to my
windows machine it repros. when I'm logged in locally, it doesn't happen.

is this dcheck still necessary?

[Ben Goodger (Google), 2013-01-07 21:17:39]

lgtm

[sky, 2013-01-07 21:59:17]

On Mon, Jan 7, 2013 at 12:35 PM,  <jam@chromium.org> wrote:
> +sky since he added the DCHECK in drag_drop_controller_unittest.cc that's
> failing.
>
> Scott: I couldn't reproduce this before, but now that I remote desktop to my
> windows machine it repros. when I'm logged in locally, it doesn't happen.
>
> is this dcheck still necessary?
>
> https://codereview.chromium.org/11787005/

I believe I added the DCHECK to try and figure out why the test was
failing. If you remove the DCHECK does the test pass?

  -Scott

[jam, 2013-01-07 22:43:43]

On 2013/01/07 21:59:17, sky wrote:
> On Mon, Jan 7, 2013 at 12:35 PM,  <mailto:jam@chromium.org> wrote:
> > +sky since he added the DCHECK in drag_drop_controller_unittest.cc that's
> > failing.
> >
> > Scott: I couldn't reproduce this before, but now that I remote desktop to my
> > windows machine it repros. when I'm logged in locally, it doesn't happen.
> >
> > is this dcheck still necessary?
> >
> > https://codereview.chromium.org/11787005/
> 
> I believe I added the DCHECK to try and figure out why the test was
> failing. If you remove the DCHECK does the test pass?

yep. I could just ifdef out the check for win aura, but before I do that I
wanted to check with you.

[sky, 2013-01-08 01:20:58]

If the test is passing go ahead and nuke the ifdef.

  -Scott

On Mon, Jan 7, 2013 at 2:43 PM,  <jam@chromium.org> wrote:
> On 2013/01/07 21:59:17, sky wrote:
>
>> On Mon, Jan 7, 2013 at 12:35 PM,  <mailto:jam@chromium.org> wrote:
>> > +sky since he added the DCHECK in drag_drop_controller_unittest.cc
>> > that's
>> > failing.
>> >
>> > Scott: I couldn't reproduce this before, but now that I remote desktop
>> > to my
>> > windows machine it repros. when I'm logged in locally, it doesn't
>> > happen.
>> >
>> > is this dcheck still necessary?
>> >
>> > https://codereview.chromium.org/11787005/
>
>
>> I believe I added the DCHECK to try and figure out why the test was
>> failing. If you remove the DCHECK does the test pass?
>
>
> yep. I could just ifdef out the check for win aura, but before I do that I
> wanted to check with you.
>
> https://codereview.chromium.org/11787005/

[sky, 2013-01-08 01:22:11]

Sorry, I meant nuke the DCHECK.

  -Scott

On Mon, Jan 7, 2013 at 5:20 PM, Scott Violet <sky@chromium.org> wrote:
> If the test is passing go ahead and nuke the ifdef.
>
>   -Scott
>
> On Mon, Jan 7, 2013 at 2:43 PM,  <jam@chromium.org> wrote:
>> On 2013/01/07 21:59:17, sky wrote:
>>
>>> On Mon, Jan 7, 2013 at 12:35 PM,  <mailto:jam@chromium.org> wrote:
>>> > +sky since he added the DCHECK in drag_drop_controller_unittest.cc
>>> > that's
>>> > failing.
>>> >
>>> > Scott: I couldn't reproduce this before, but now that I remote desktop
>>> > to my
>>> > windows machine it repros. when I'm logged in locally, it doesn't
>>> > happen.
>>> >
>>> > is this dcheck still necessary?
>>> >
>>> > https://codereview.chromium.org/11787005/
>>
>>
>>> I believe I added the DCHECK to try and figure out why the test was
>>> failing. If you remove the DCHECK does the test pass?
>>
>>
>> yep. I could just ifdef out the check for win aura, but before I do that I
>> wanted to check with you.
>>
>> https://codereview.chromium.org/11787005/