Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: ash/drag_drop/drag_drop_controller.cc

Issue 11787005: Get drag and drop working on Win Ash. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync and take out dcheck for win Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/drag_drop/drag_drop_controller.cc
===================================================================
--- ash/drag_drop/drag_drop_controller.cc (revision 175409)
+++ ash/drag_drop/drag_drop_controller.cc (working copy)
@@ -19,7 +19,7 @@
#include "ui/aura/window.h"
#include "ui/base/animation/linear_animation.h"
#include "ui/base/dragdrop/drag_drop_types.h"
-#include "ui/base/dragdrop/os_exchange_data_provider_aura.h"
+#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/base/events/event.h"
#include "ui/base/events/event_utils.h"
#include "ui/gfx/point.h"
@@ -112,22 +112,10 @@
if (IsDragDropInProgress())
return 0;
-#if defined(OS_WIN)
- // TODO(win_ash): need to figure out how this will work in Metro, since
- // OSExchangeDataProviderAura isn't used in Windows builds. Two alternatives:
- // 1) Use OSExchangeDataProviderAura in Ash and OSExchangeDataProviderWin
- // elsewhere. This will complicate creating an ui::OSExchangeData to pass
- // in more context.
- // 2) Add methods to get the image and offset in the base interface of these
- // implementations to get to this data here.
- NOTIMPLEMENTED();
- return 0;
-#else
- const ui::OSExchangeDataProviderAura& provider =
- static_cast<const ui::OSExchangeDataProviderAura&>(data.provider());
+ const ui::OSExchangeData::Provider* provider = &data.provider();
// We do not support touch drag/drop without a drag image.
if (source == ui::DragDropTypes::DRAG_EVENT_SOURCE_TOUCH &&
- provider.drag_image().size().IsEmpty())
+ provider->GetDragImage().size().IsEmpty())
return 0;
current_drag_event_source_ = source;
@@ -162,11 +150,11 @@
gfx::Point start_location = root_location;
ash::wm::ConvertPointToScreen(root_window, &start_location);
drag_image_final_bounds_for_cancel_animation_ = gfx::Rect(
- start_location - provider.drag_image_offset(),
- provider.drag_image().size());
+ start_location - provider->GetDragImageOffset(),
+ provider->GetDragImage().size());
drag_image_.reset(new DragImageView);
- drag_image_->SetImage(provider.drag_image());
- drag_image_offset_ = provider.drag_image_offset();
+ drag_image_->SetImage(provider->GetDragImage());
+ drag_image_offset_ = provider->GetDragImageOffset();
gfx::Rect drag_image_bounds(start_location, drag_image_->GetPreferredSize());
drag_image_bounds = AdjustDragImageBoundsForScaleAndOffset(drag_image_bounds,
drag_image_vertical_offset, drag_image_scale, &drag_image_offset_);
@@ -197,7 +185,6 @@
drag_source_window_->RemoveObserver(this);
drag_source_window_ = NULL;
}
-#endif
return drag_operation_;
}
« no previous file with comments | « ash/ash.gyp ('k') | ash/drag_drop/drag_drop_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698