Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1178683004: Revert of [turbofan] Record the SharedFunctionInfo of ALL inlined functions. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Record the SharedFunctionInfo of ALL inlined functions. (patchset #2 id:20001 of https://codereview.chromium.org/1175953002/) Reason for revert: Breaks Windows debug. Original issue's description: > [turbofan] Record the SharedFunctionInfo of ALL inlined functions. > > Previously we only recorded the SharedFunctionInfo of inlined functions > that had at least one (lazy) deopt point left at code generation time. > > R=mstarzinger@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1c49127d3eb1021b03c3ad11f0f7ebf294ef22ad Cr-Commit-Position: refs/heads/master@{#28920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M src/compiler.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [turbofan] Record the SharedFunctionInfo of ALL inlined functions.
5 years, 6 months ago (2015-06-11 04:47:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178683004/1
5 years, 6 months ago (2015-06-11 04:47:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 04:47:44 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 04:47:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c49127d3eb1021b03c3ad11f0f7ebf294ef22ad
Cr-Commit-Position: refs/heads/master@{#28920}

Powered by Google App Engine
This is Rietveld 408576698