Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1175953002: [turbofan] Record the SharedFunctionInfo of ALL inlined functions. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Record the SharedFunctionInfo of ALL inlined functions. Previously we only recorded the SharedFunctionInfo of inlined functions that had at least one (lazy) deopt point left at code generation time. R=mstarzinger@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 Committed: https://crrev.com/c5c27dd5d99d135893e1a8696994372550b77488 Cr-Commit-Position: refs/heads/master@{#28922}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Cannot use a ZoneVector because of smart... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/compiler.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-10 11:55:34 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, record the inlined functions on the CompilationInfo for TurboFan. Please ...
5 years, 6 months ago (2015-06-10 11:58:11 UTC) #2
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-10 12:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175953002/20001
5 years, 6 months ago (2015-06-10 12:04:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/4629)
5 years, 6 months ago (2015-06-10 12:16:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175953002/20001
5 years, 6 months ago (2015-06-11 04:17:43 UTC) #9
Benedikt Meurer
Committed patchset #2 (id:20001) manually as ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 (presubmit successful).
5 years, 6 months ago (2015-06-11 04:34:38 UTC) #11
Benedikt Meurer
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1178683004/ by bmeurer@chromium.org. ...
5 years, 6 months ago (2015-06-11 04:47:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175953002/40001
5 years, 6 months ago (2015-06-11 04:56:52 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 05:23:11 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 05:23:20 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5c27dd5d99d135893e1a8696994372550b77488
Cr-Commit-Position: refs/heads/master@{#28922}

Powered by Google App Engine
This is Rietveld 408576698