Get rid of DEFINE_TESTCLASS_SHORT() macro.

Get rid of DEFINE_TESTCLASS_SHORT() macro.

Instead tests should be written using DEF_TEST() macro, which is much
nicer and simplifies the process of setting up an unit test.

BUG=None
TEST=skpskgr_test, pathops_unittest
R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12870

[tfarina, 2013-12-24 00:29:07]

Merry Christmas!

Man, these PathOps tests blew my mind!

[tfarina, 2014-01-02 00:22:39]

friendly ping?

[mtklein, 2014-01-02 17:51:06]

Looks good.  Just some small stuff to fix up before we can submit.

https://codereview.chromium.org/117863005/diff/70001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (left):

https://codereview.chromium.org/117863005/diff/70001/src/core/SkCanvas.cpp#ol...
src/core/SkCanvas.cpp:1459: static inline int pinIntForScalar(int x) {
Just did this one for you.  Should merge away?

https://codereview.chromium.org/117863005/diff/70001/tests/PathOpsAngleTest.cpp
File tests/PathOpsAngleTest.cpp (right):

https://codereview.chromium.org/117863005/diff/70001/tests/PathOpsAngleTest.c...
tests/PathOpsAngleTest.cpp:455: DEF_TEST(PathOpsAngleFindSlop, reporter) {
Can you block-comment this one out?  I'm not clear on why it used to be
disabled, so I'd rather just keep it off.

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp
File tests/SkpSkGrTest.cpp (right):

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp#ne...
tests/SkpSkGrTest.cpp:52: // static const size_t skipOverSkGrCount = 0; //
SK_ARRAY_COUNT(skipOverSkGr);
Let's revert everything related to this.  It looks like this is a debugging knob
that we're just making less convenient to use by commenting it out.

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp#ne...
tests/SkpSkGrTest.cpp:518: //SkAssertResult(reader.read(&c, 1) != 0);
This is not a no-op.  SkAssertResult always evaluates its argument, so you're
disabling the call to read here.  Please undo.

[tfarina, 2014-01-02 21:09:07]

Thanks Mike!

I don't remember why clang complained and I had to comment the code in
SkpSkGrTest.cpp, but now it passed fine.

https://codereview.chromium.org/117863005/diff/70001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (left):

https://codereview.chromium.org/117863005/diff/70001/src/core/SkCanvas.cpp#ol...
src/core/SkCanvas.cpp:1459: static inline int pinIntForScalar(int x) {
On 2014/01/02 17:51:07, mtklein wrote:
> Just did this one for you.  Should merge away?

Done.

https://codereview.chromium.org/117863005/diff/70001/tests/PathOpsAngleTest.cpp
File tests/PathOpsAngleTest.cpp (right):

https://codereview.chromium.org/117863005/diff/70001/tests/PathOpsAngleTest.c...
tests/PathOpsAngleTest.cpp:455: DEF_TEST(PathOpsAngleFindSlop, reporter) {
On 2014/01/02 17:51:07, mtklein wrote:
> Can you block-comment this one out?  I'm not clear on why it used to be
> disabled, so I'd rather just keep it off.

Done.

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp
File tests/SkpSkGrTest.cpp (right):

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp#ne...
tests/SkpSkGrTest.cpp:52: // static const size_t skipOverSkGrCount = 0; //
SK_ARRAY_COUNT(skipOverSkGr);
On 2014/01/02 17:51:07, mtklein wrote:
> Let's revert everything related to this.  It looks like this is a debugging
knob
> that we're just making less convenient to use by commenting it out.

Done.

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp#ne...
tests/SkpSkGrTest.cpp:518: //SkAssertResult(reader.read(&c, 1) != 0);
On 2014/01/02 17:51:07, mtklein wrote:
> This is not a no-op.  SkAssertResult always evaluates its argument, so you're
> disabling the call to read here.  Please undo.

Done.

https://codereview.chromium.org/117863005/diff/70001/tests/SkpSkGrTest.cpp#ne...
tests/SkpSkGrTest.cpp:518: //SkAssertResult(reader.read(&c, 1) != 0);
On 2014/01/02 17:51:07, mtklein wrote:
> This is not a no-op.  SkAssertResult always evaluates its argument, so you're
> disabling the call to read here.  Please undo.

Done.

[mtklein, 2014-01-02 21:17:25]

lgtm

[commit-bot: I haz the power, 2014-01-02 21:17:30]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/117863005/440001

[tfarina, 2014-01-02 21:45:33]

Committed patchset #5 manually as r12870 (presubmit successful).