Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: tests/SkpSkGrTest.cpp

Issue 117863005: Get rid of DEFINE_TESTCLASS_SHORT() macro. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Mike review Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/PathOpsTypesTest.cpp ('k') | tests/TestClassDef.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SkpSkGrTest.cpp
diff --git a/tests/SkpSkGrTest.cpp b/tests/SkpSkGrTest.cpp
index 1f0529e016053ec6d61194472d694d70c828f4ce..a896517c56f01e9dd7abf1726d41425c47fc431e 100755
--- a/tests/SkpSkGrTest.cpp
+++ b/tests/SkpSkGrTest.cpp
@@ -26,6 +26,7 @@
#include "SkThreadPool.h"
#include "SkTime.h"
#include "Test.h"
+#include "TestClassDef.h"
#ifdef SK_BUILD_FOR_WIN
#define PATH_SLASH "\\"
@@ -36,7 +37,7 @@
#define PATH_SLASH "/"
#define IN_DIR "/usr/local/google/home/caryclark" PATH_SLASH "9-30-13-skp"
#define OUT_DIR "/media/01CD75512A7F9EE0/4" PATH_SLASH
- #define LINE_FEED \n"
+ #define LINE_FEED "\n"
#endif
#define PATH_STR_SIZE 512
@@ -572,7 +573,7 @@ static bool initTest() {
return make_out_dirs();
}
-static void SkpSkGrTest(skiatest::Reporter* reporter) {
+DEF_TEST(SkpSkGr, reporter) {
SkTArray<TestResult, true> errors;
if (!initTest()) {
return;
@@ -628,8 +629,8 @@ static void SkpSkGrTest(skiatest::Reporter* reporter) {
SkDebugf("#%d\n", testCount);
}
}
- skipOver:
- reporter->bumpTestCount();
+ skipOver:
+ reporter->bumpTestCount();
checkEarlyExit:
if (1 && testCount == 20) {
break;
@@ -669,7 +670,7 @@ static void testSkGrMain(SkpSkGrThreadState* data) {
data->fReporter->bumpTestCount();
}
-static void SkpSkGrThreadedTest(skiatest::Reporter* reporter) {
+DEF_TEST(SkpSkGrThreaded, reporter) {
if (!initTest()) {
return;
}
@@ -736,7 +737,7 @@ static void SkpSkGrThreadedTest(skiatest::Reporter* reporter) {
}
}
-static void SkpSkGrOneOffTest(skiatest::Reporter* reporter) {
+DEF_TEST(SkpSkGrOneOff, reporter) {
if (!initTest()) {
return;
}
@@ -750,10 +751,3 @@ static void SkpSkGrOneOffTest(skiatest::Reporter* reporter) {
TestResult::Test(dirIndex, filename.c_str(), kCompareBits, reporter->verbose());
TestResult::Test(dirIndex, filename.c_str(), kEncodeFiles, reporter->verbose());
}
-
-#include "TestClassDef.h"
-DEFINE_TESTCLASS_SHORT(SkpSkGrTest)
-
-DEFINE_TESTCLASS_SHORT(SkpSkGrOneOffTest)
-
-DEFINE_TESTCLASS_SHORT(SkpSkGrThreadedTest)
« no previous file with comments | « tests/PathOpsTypesTest.cpp ('k') | tests/TestClassDef.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698