Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11785038: Update and rebaseline many DumpAccessibilityTree tests. (Closed)

Created:
7 years, 11 months ago by dmazzoni
Modified:
7 years, 11 months ago
Reviewers:
David Tseng, aboxhall
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, sail+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update and rebaseline many DumpAccessibilityTree tests. This re-enables several tests that were disabled, and adds new expectations where they were missing before. It also cleans up some tests by suppressing unnecessary attributes, and makes the Mac "subrole" attribute hidden by default since it's rarely useful. The correctness of the output was determined by these specs: HTML: http://www.w3.org/TR/html-aapi/ ARIA: http://www.w3.org/WAI/PF/aria-implementation/ BUG=165838 TBR=dtseng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175687

Patch Set 1 #

Total comments: 6

Patch Set 2 : remove bug comments that no longer apply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -99 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 4 chunks +4 lines, -21 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/a-expected-mac.txt View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/data/accessibility/a-name.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/a-with-img.html View 1 chunk +7 lines, -4 lines 0 comments Download
M content/test/data/accessibility/a-with-img-expected-mac.txt View 1 chunk +16 lines, -1 line 0 comments Download
M content/test/data/accessibility/a-with-img-expected-win.txt View 1 chunk +16 lines, -17 lines 0 comments Download
M content/test/data/accessibility/aria-application.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria-combobox.html View 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-combobox-expected-mac.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/aria-combobox-expected-win.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-menu.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/button-name-calc.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/button-name-calc-expected-mac.txt View 1 chunk +8 lines, -1 line 0 comments Download
M content/test/data/accessibility/canvas-expected-mac.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/canvas-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/checkbox-name-calc.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/checkbox-name-calc-expected-mac.txt View 1 chunk +8 lines, -1 line 0 comments Download
M content/test/data/accessibility/contenteditable-descendants-expected-win.txt View 1 chunk +19 lines, -18 lines 0 comments Download
M content/test/data/accessibility/div.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/footer.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/form-expected-mac.txt View 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/accessibility/input-range.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/label-expected-mac.txt View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/data/accessibility/list-markers.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/p-expected-mac.txt View 1 chunk +7 lines, -1 line 0 comments Download
M content/test/data/accessibility/spinbutton-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/togglebutton-expected-mac.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/togglebutton-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/ul.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
7 years, 11 months ago (2013-01-08 07:53:40 UTC) #1
aboxhall
https://codereview.chromium.org/11785038/diff/1/content/browser/accessibility/dump_accessibility_tree_browsertest.cc File content/browser/accessibility/dump_accessibility_tree_browsertest.cc (right): https://codereview.chromium.org/11785038/diff/1/content/browser/accessibility/dump_accessibility_tree_browsertest.cc#newcode240 content/browser/accessibility/dump_accessibility_tree_browsertest.cc:240: // Tracked in http://crbug.com/165838 Is this comment still necessary? ...
7 years, 11 months ago (2013-01-08 16:43:51 UTC) #2
dmazzoni
https://codereview.chromium.org/11785038/diff/1/content/browser/accessibility/dump_accessibility_tree_browsertest.cc File content/browser/accessibility/dump_accessibility_tree_browsertest.cc (right): https://codereview.chromium.org/11785038/diff/1/content/browser/accessibility/dump_accessibility_tree_browsertest.cc#newcode240 content/browser/accessibility/dump_accessibility_tree_browsertest.cc:240: // Tracked in http://crbug.com/165838 On 2013/01/08 16:43:51, aboxhall wrote: ...
7 years, 11 months ago (2013-01-08 18:21:01 UTC) #3
aboxhall
lgtm
7 years, 11 months ago (2013-01-08 18:22:06 UTC) #4
dmazzoni
+dtseng (need a full reviewer)
7 years, 11 months ago (2013-01-08 18:28:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11785038/1031
7 years, 11 months ago (2013-01-09 00:05:33 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 03:01:12 UTC) #7
Message was sent while issue was closed. 
Change committed as 175687

Powered by Google App Engine
This is Rietveld 408576698