Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 11785038: Update and rebaseline many DumpAccessibilityTree tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove bug comments that no longer apply Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_helper_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 72b07bd7f95156e1c9f0747f228079f644d4aa59..1c3ca595a1cb5e9910ad199202d36da2a8ef6423 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -236,10 +236,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
RunTest(FILE_PATH_LITERAL("aria-application.html"));
}
-// Broken by http://trac.webkit.org/137512
-// Tracked in http://crbug.com/165838
-IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityAriaCombobox) {
+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaCombobox) {
RunTest(FILE_PATH_LITERAL("aria-combobox.html"));
}
@@ -255,10 +252,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityButtonNameCalc) {
RunTest(FILE_PATH_LITERAL("button-name-calc.html"));
}
-// TODO(dmazzoni): rebaseline and enable after this WebKit change is rolled:
-// https://bugs.webkit.org/show_bug.cgi?id=96323
-IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityCanvas) {
+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityCanvas) {
RunTest(FILE_PATH_LITERAL("canvas.html"));
}
@@ -267,21 +261,12 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
RunTest(FILE_PATH_LITERAL("checkbox-name-calc.html"));
}
-// TODO(dimich): Started to fail in Chrome r149732 (crbug 140397)
-#if defined(OS_WIN)
-#define MAYBE_AccessibilityContenteditableDescendants \
- DISABLED_AccessibilityContenteditableDescendants
-#else
-#define MAYBE_AccessibilityContenteditableDescendants \
- AccessibilityContenteditableDescendants
-#endif
-
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityDiv) {
RunTest(FILE_PATH_LITERAL("div.html"));
}
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- MAYBE_AccessibilityContenteditableDescendants) {
+ AccessibilityContenteditableDescendants) {
RunTest(FILE_PATH_LITERAL("contenteditable-descendants.html"));
}
@@ -322,10 +307,8 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilitySpinButton) {
RunTest(FILE_PATH_LITERAL("spinbutton.html"));
}
-// TODO(dmazzoni): rebaseline and enable after this WebKit change is rolled:
-// https://bugs.webkit.org/show_bug.cgi?id=96323
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityToggleButton) {
+ AccessibilityToggleButton) {
RunTest(FILE_PATH_LITERAL("togglebutton.html"));
}
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_helper_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698