Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1178403003: Revert of Keep track of array buffers in new space separately (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Keep track of array buffers in new space separately (patchset #4 id:60001 of https://codereview.chromium.org/1133773002/) Reason for revert: GC stress unhappy Original issue's description: > Keep track of array buffers in new space separately > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc > Cr-Commit-Position: refs/heads/master@{#28978} TBR=hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6 Cr-Commit-Position: refs/heads/master@{#28979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -180 lines) Patch
M src/api.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/heap.h View 3 chunks +5 lines, -40 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +32 lines, -118 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +1 line, -6 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of Keep track of array buffers in new space separately
5 years, 6 months ago (2015-06-12 06:28:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178403003/1
5 years, 6 months ago (2015-06-12 06:29:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 06:29:11 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 06:29:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64ba57ce612ad698dec64135a5cf57990ffd55f6
Cr-Commit-Position: refs/heads/master@{#28979}

Powered by Google App Engine
This is Rietveld 408576698