Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/heap/heap.h

Issue 1178403003: Revert of Keep track of array buffers in new space separately (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 92519ad3d84f22945d1249c4886bad4277ebcb66..e30e40c121a607134596e0d7207037cd98900d4b 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1567,28 +1567,10 @@
bool deserialization_complete() const { return deserialization_complete_; }
- // The following methods are used to track raw C++ pointers to externally
- // allocated memory used as backing store in live array buffers.
-
- // A new ArrayBuffer was created with |data| as backing store.
- void RegisterNewArrayBuffer(bool in_new_space, void* data, size_t length);
-
- // The backing store |data| is no longer owned by V8.
- void UnregisterArrayBuffer(bool in_new_space, void* data);
-
- // A live ArrayBuffer was discovered during marking/scavenge.
- void RegisterLiveArrayBuffer(bool in_new_space, void* data);
-
- // Frees all backing store pointers that weren't discovered in the previous
- // marking or scavenge phase.
- void FreeDeadArrayBuffers(bool in_new_space);
-
- // Prepare for a new scavenge phase. A new marking phase is implicitly
- // prepared by finishing the previous one.
- void PrepareArrayBufferDiscoveryInNewSpace();
-
- // An ArrayBuffer moved from new space to old space.
- void PromoteArrayBuffer(Object* buffer);
+ void RegisterNewArrayBuffer(void* data, size_t length);
+ void UnregisterArrayBuffer(void* data);
+ void RegisterLiveArrayBuffer(void* data);
+ void FreeDeadArrayBuffers();
protected:
// Methods made available to tests.
@@ -2092,23 +2074,8 @@
// the old space.
void EvaluateOldSpaceLocalPretenuring(uint64_t size_of_objects_before_gc);
- // Called on heap tear-down. Frees all remaining ArrayBuffer backing stores.
+ // Called on heap tear-down.
void TearDownArrayBuffers();
-
- // These correspond to the non-Helper versions.
- void RegisterNewArrayBufferHelper(std::map<void*, size_t>& live_buffers,
- void* data, size_t length);
- void UnregisterArrayBufferHelper(
- std::map<void*, size_t>& live_buffers,
- std::map<void*, size_t>& not_yet_discovered_buffers, void* data);
- void RegisterLiveArrayBufferHelper(
- std::map<void*, size_t>& not_yet_discovered_buffers, void* data);
- size_t FreeDeadArrayBuffersHelper(
- Isolate* isolate, std::map<void*, size_t>& live_buffers,
- std::map<void*, size_t>& not_yet_discovered_buffers);
- void TearDownArrayBuffersHelper(
- Isolate* isolate, std::map<void*, size_t>& live_buffers,
- std::map<void*, size_t>& not_yet_discovered_buffers);
// Record statistics before and after garbage collection.
void ReportStatisticsBeforeGC();
@@ -2352,9 +2319,7 @@
bool concurrent_sweeping_enabled_;
std::map<void*, size_t> live_array_buffers_;
- std::map<void*, size_t> live_new_array_buffers_;
std::map<void*, size_t> not_yet_discovered_array_buffers_;
- std::map<void*, size_t> not_yet_discovered_new_array_buffers_;
struct StrongRootsList;
StrongRootsList* strong_roots_list_;
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698