Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11784007: [Telemetry] Allow telemetry to run without adb root. (Closed)

Created:
7 years, 11 months ago by tonyg
Modified:
7 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org, Ian Vollick
Visibility:
Public.

Description

[Telemetry] Allow telemetry to run without adb root. Without root the user must manually enable devtools debugging in settings. This limitation is acceptable as we are able to detect it and instruct the user. BUG=154415 TEST=Run a telemetry test on a production android image Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175353

Patch Set 1 #

Patch Set 2 : Fix application quitting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M tools/telemetry/telemetry/adb_commands.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/android_browser_backend.py View 1 5 chunks +11 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/android_browser_finder.py View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
ptal I can't believe it was this easy
7 years, 11 months ago (2013-01-04 22:53:06 UTC) #1
nduca
this looks awesome. I think we may need to resolve the kill problem though.
7 years, 11 months ago (2013-01-05 01:17:15 UTC) #2
tonyg
On 2013/01/05 01:17:15, nduca wrote: > this looks awesome. I think we may need to ...
7 years, 11 months ago (2013-01-05 01:39:52 UTC) #3
nduca
the hills are alive with the sound of lgtmmmmmmmnesss.
7 years, 11 months ago (2013-01-05 02:03:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/11784007/4001
7 years, 11 months ago (2013-01-05 20:32:30 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 20:46:38 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 16:55:06 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698