Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/telemetry/telemetry/android_browser_finder.py

Issue 11784007: [Telemetry] Allow telemetry to run without adb root. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix application quitting Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/android_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/android_browser_finder.py
diff --git a/tools/telemetry/telemetry/android_browser_finder.py b/tools/telemetry/telemetry/android_browser_finder.py
index aa66d28046b67c42437a42292990439b23a9a5d9..f10bd96829fa706cde5b58e87ca910f8abd925a0 100644
--- a/tools/telemetry/telemetry/android_browser_finder.py
+++ b/tools/telemetry/telemetry/android_browser_finder.py
@@ -103,12 +103,6 @@ def FindAllAvailableBrowsers(options, logging=real_logging):
adb = adb_commands.AdbCommands(device=device)
- # See if adb is root
- if not adb.IsRootEnabled():
- logging.warn('ADB is not root. Please make it root by doing:')
- logging.warn(' adb root')
- return []
-
packages = adb.RunShellCommand('pm list packages')
possible_browsers = []
if 'package:' + CONTENT_SHELL_PACKAGE in packages:
« no previous file with comments | « tools/telemetry/telemetry/android_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698