Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1178383003: Revert of Make GrTextContext be owned by the GrDrawContext (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrTextContext be owned by the GrDrawContext (patchset #7 id:120001 of https://codereview.chromium.org/1175553002/) Reason for revert: Breaking Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug ? https://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/436/steps/dm/logs/stdio Original issue's description: > Make GrTextContext be owned by the GrDrawContext > > This CL makes the GrTextContext be owned (and hidden) by the GrDrawContext. This funnels all the drawText* calls through the GrDrawContext and hides the (dispreferred) GrPipelineBuilder drawText variant. > > Some consequences of this are: > > GrDrawContext now has to get the text drawing settings (i.e., SkDeviceProperties & useDFT). This means that we need a separate GrDrawContext for each combination of pixel geometry and DFT-use. > > All the GrTextContext-derived classes now get a back pointer to the originating GrDrawContext so their method calls no longer take one. > > Committed: https://skia.googlesource.com/skia/+/5b16e740fe6ab6d679083d06f07651602265081b TBR=joshualitt@chromium.org,joshualitt@google.com,jvanverth@google.com,reed@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/781d58215f03cfe43c6b5f7bf1a578bc3c9a1e6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -296 lines) Patch
M include/gpu/GrContext.h View 5 chunks +27 lines, -22 lines 0 comments Download
M include/gpu/GrDrawContext.h View 4 chunks +10 lines, -37 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDeviceProperties.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 4 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 15 chunks +57 lines, -50 lines 0 comments Download
M src/gpu/GrContext.cpp View 5 chunks +24 lines, -34 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 4 chunks +4 lines, -70 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 3 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 7 chunks +25 lines, -25 lines 0 comments Download
M src/gpu/GrTextContext.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 8 chunks +22 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Make GrTextContext be owned by the GrDrawContext
5 years, 6 months ago (2015-06-16 22:02:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178383003/1
5 years, 6 months ago (2015-06-16 22:03:04 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 22:03:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/781d58215f03cfe43c6b5f7bf1a578bc3c9a1e6f

Powered by Google App Engine
This is Rietveld 408576698