Issue 11783052: Fix chainToCompleter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11783052: Fix chainToCompleter. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom

Modified:
7 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix chainToCompleter. Committed: https://code.google.com/p/dart/source/detail?r=16833

Patch Set 3 : Fix style 2. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	utils/pub/utils.dart	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
	M	utils/tests/pub/test_pub.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11783052/diff/1/utils/pub/utils.dart File utils/pub/utils.dart (right): https://codereview.chromium.org/11783052/diff/1/utils/pub/utils.dart#newcode124 utils/pub/utils.dart:124: onError: (e) =>completer.completeError(e.error, e.stackTrace)); Nit: need a space ...

7 years, 11 months ago (2013-01-09 02:24:50 UTC) #2

Bob Nystrom

7 years, 11 months ago (2013-01-09 02:26:41 UTC) #3

Thanks!

https://codereview.chromium.org/11783052/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://codereview.chromium.org/11783052/diff/1/utils/pub/utils.dart#newcode124
utils/pub/utils.dart:124: onError: (e) =>completer.completeError(e.error,
e.stackTrace));
On 2013/01/09 02:24:50, nweiz wrote:
> Nit: need a space between "=>" and "completer".

Oopsie. Done.

https://codereview.chromium.org/11783052/diff/1/utils/pub/utils.dart#newcode125
utils/pub/utils.dart:125: 
On 2013/01/09 02:24:50, nweiz wrote:
> Extra line

Done.

Expand Messages | Collapse Messages

Issue 11783052: Fix chainToCompleter. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix style. #

Patch Set 3 : Fix style 2. #

Messages