Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/pub/utils.dart

Issue 11783052: Fix chainToCompleter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix style 2. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/utils.dart
diff --git a/utils/pub/utils.dart b/utils/pub/utils.dart
index 9094984adcf3d37cd926fc35546b61e243c9a735..2a800fa0ce59bd7d67e824321d220fcc218fbd20 100644
--- a/utils/pub/utils.dart
+++ b/utils/pub/utils.dart
@@ -120,11 +120,8 @@ Future sleep(int milliseconds) {
/// Configures [future] so that its result (success or exception) is passed on
/// to [completer].
void chainToCompleter(Future future, Completer completer) {
- future
- .then(completer.complete)
- .catchError((e) {
- completer.completeError(e.error, e.stackTrace);
- });
+ future.then((value) => completer.complete(value),
+ onError: (e) => completer.completeError(e.error, e.stackTrace));
}
// TODO(nweiz): unify the following functions with the utility functions in
« no previous file with comments | « no previous file | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698