Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/bots/compiler.py

Issue 11783027: Small improvement on the "delete temp dir on windows"-hack in the annotated steps script (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
diff --git a/tools/bots/compiler.py b/tools/bots/compiler.py
index 9e88f2c140303d03f0b9cbcf5de7e0d5e3560195..0d3e9232e1a2aa673105de0fa69ed17b99152e01 100644
--- a/tools/bots/compiler.py
+++ b/tools/bots/compiler.py
@@ -257,8 +257,9 @@ def CleanUpTemporaryFiles(system, browser):
- browser: one of the browsers, see GetBuildInfo
"""
if system.startswith('win'):
- shutil.rmtree('C:\\Users\\chrome-bot\\AppData\\Local\\Temp',
- ignore_errors=True)
+ temp_dir = 'C:\\Users\\chrome-bot\\AppData\\Local\\Temp'
+ for name in os.listdir(temp_dir):
ricow1 2013/01/08 10:39:37 Should we do: for root, dirs, files in os.walk(tem
kustermann 2013/01/08 11:24:49 Let's delete only directories, this hack only exis
+ shutil.rmtree(temp_dir + "\\" + name, ignore_errors=True)
elif browser == 'ff' or 'opera':
# Note: the buildbots run as root, so we can do this without requiring a
# password. The command won't actually work on regular machines without
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698