Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1178213003: Introduce sky_packager (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Introduce sky_packager sky_packager is a tool that generates a Dart script snapshot for Dart files intended to run with dart:sky. I plan to use this tool to experiment with startup performance. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b2de7a8d482b9465e78a41b1b69d5c958d76f7e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -29 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/tools/packager/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A sky/tools/packager/loader.h View 1 chunk +18 lines, -0 lines 0 comments Download
A sky/tools/packager/loader.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A + sky/tools/packager/logging.h View 1 chunk +7 lines, -12 lines 0 comments Download
A + sky/tools/packager/logging.cc View 2 chunks +13 lines, -11 lines 0 comments Download
A sky/tools/packager/main.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A sky/tools/packager/scope.h View 1 chunk +33 lines, -0 lines 0 comments Download
A sky/tools/packager/switches.h View 1 chunk +11 lines, -0 lines 0 comments Download
A + sky/tools/packager/switches.cc View 1 chunk +3 lines, -6 lines 0 comments Download
A sky/tools/packager/vm.h View 1 chunk +13 lines, -0 lines 0 comments Download
A sky/tools/packager/vm.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-15 08:09:17 UTC) #1
jackson
rubber-stamp lgtm
5 years, 6 months ago (2015-06-15 16:46:00 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-15 17:42:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2de7a8d482b9465e78a41b1b69d5c958d76f7e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698