Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: sky/tools/packager/logging.cc

Issue 1178213003: Introduce sky_packager (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/tools/packager/logging.h ('k') | sky/tools/packager/main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/tools/packager/logging.h"
6 #include "sky/engine/tonic/dart_error.h"
7 6
8 #include "base/logging.h" 7 #include "base/logging.h"
9 8
10 namespace blink {
11
12 namespace DartError {
13
14 const char kInvalidArgument[] = "Invalid argument.";
15
16 } // namespace DartError
17
18 bool LogIfError(Dart_Handle handle) { 9 bool LogIfError(Dart_Handle handle) {
19 if (Dart_IsError(handle)) { 10 if (Dart_IsError(handle)) {
20 LOG(ERROR) << Dart_GetError(handle); 11 LOG(ERROR) << Dart_GetError(handle);
21 12
22 // Only unhandled exceptions have stacktraces. 13 // Only unhandled exceptions have stacktraces.
23 if (!Dart_ErrorHasException(handle)) 14 if (!Dart_ErrorHasException(handle))
24 return true; 15 return true;
25 16
26 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle); 17 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle);
27 const char* stacktrace_cstr = ""; 18 const char* stacktrace_cstr = "";
28 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr); 19 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr);
29 LOG(ERROR) << stacktrace_cstr; 20 LOG(ERROR) << stacktrace_cstr;
30 return true; 21 return true;
31 } 22 }
32 return false; 23 return false;
33 } 24 }
34 25
35 } // namespace blink 26 std::string StringFromDart(Dart_Handle string) {
27 CHECK(Dart_IsString(string));
28 uint8_t* utf8_array;
29 intptr_t length;
30 Dart_StringToUTF8(string, &utf8_array, &length);
31 return std::string(reinterpret_cast<const char*>(utf8_array), length);
32 }
33
34 Dart_Handle StringToDart(const std::string& string) {
35 return Dart_NewStringFromUTF8(reinterpret_cast<const uint8_t*>(string.data()),
36 string.length());
37 }
OLDNEW
« no previous file with comments | « sky/tools/packager/logging.h ('k') | sky/tools/packager/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698