Issue 1178063004: Oilpan: move "forced GC" handling back to gcEpilogue().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178063004: Oilpan: move "forced GC" handling back to gcEpilogue(). (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, arv+blink, oilpan-reviews, Mads Ager (chromium), vivekg_samsung, vivekg, blink-reviews-bindings_chromium.org, kouhei+heap_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: move "forced GC" handling back to gcEpilogue(). Some tests assume that minor GCs (via GCController.minorCollect()) will also force an Oilpan GC. Hence, revert r196953's move of forced GC handling (to ThreadState::didV8MajorGC()), moving it back to gcEpilogue() so that all V8 GC notifications might again trigger a forced GC. R= BUG=420515

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -21 lines)			Patch
M	Source/bindings/core/v8/V8GCController.cpp	View	1 2	1 chunk	+18 lines, -1 line	0 comments	Download
M	Source/platform/heap/ThreadState.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/heap/ThreadState.cpp	View		2 chunks	+1 line, -19 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. takes care of the fast/dom/minor-dom-gc.html leak regression.

5 years, 6 months ago (2015-06-15 12:43:02 UTC) #2

sof

5 years, 6 months ago (2015-06-17 13:19:08 UTC) #4

Thanks - end up being included in https://codereview.chromium.org/1190513006/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1178063004: Oilpan: move "forced GC" handling back to gcEpilogue(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : adjust force-gc logic #

Patch Set 3 : compile fix #

Messages