Include-what-you-use cleanup for http_cache_transaction.*

net/http/http_cache_transaction.h

Index: net/http/http_cache_transaction.h
diff --git a/net/http/http_cache_transaction.h b/net/http/http_cache_transaction.h
index cbf092907a99869813309f9590b7bfae8c6a2cbc..d671d23dbd4d631fc5cb143b436de9165f17472e 100644
--- a/net/http/http_cache_transaction.h
+++ b/net/http/http_cache_transaction.h
@@ -10,19 +10,28 @@
 

[gavinp, 2015/06/17 13:56:14]

Should we also #include <stddef.h> for size_t?

(in an earlier comment on another review, I think I referred to <stdint.h> for
this?)

[Adam Rice, 2015/06/19 07:00:01]

Done.

This file still uses the deprecated integer types from basictypes.h. Changing
those would be more disruptive, so I left them alone.

 #include <string>
 
+#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "net/base/completion_callback.h"
+#include "net/base/load_states.h"
 #include "net/base/request_priority.h"
+#include "net/base/upload_progress.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/http/http_transaction.h"
+#include "net/http/partial_data.h"
 #include "net/log/net_log.h"
 #include "net/socket/connection_attempts.h"
+#include "net/websockets/websocket_handshake_stream_base.h"
 
 namespace net {
 
+class IOBuffer;

[gavinp, 2015/06/17 13:56:14]

We use a scoped_refptr of IOBuffer (read_buf_ on line 462). That makes using a
forward declaration quite fragile; if any constructors or destructors are
generated then we could blow up. Should we just add an include?

(I didn't know this even worked! I spent some time playing with it to convince
myself that clang at least compiles scoped_refptr to a forward declared class,
although it is pretty easy to generate a method that blows it up...)

[Adam Rice, 2015/06/19 07:00:01]

No point in unnecessary excitement. I moved the io_buffer.h include to this
file.

 class PartialData;
 struct HttpRequestInfo;
 struct LoadTimingInfo;