Include-what-you-use cleanup for http_cache_transaction.*

net/http/http_cache_transaction.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares HttpCache::Transaction, a private class of HttpCache so
 // it should only be included by http_cache.cc
 
 #ifndef NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 #define NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 

[gavinp, 2015/06/17 13:56:14]

Should we also #include <stddef.h> for size_t?

(in an earlier comment on another review, I think I referred to <stdint.h> for
this?)

[Adam Rice, 2015/06/19 07:00:01]

Done.

This file still uses the deprecated integer types from basictypes.h. Changing
those would be more disruptive, so I left them alone.

 #include <string>
 
+#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "net/base/completion_callback.h"
+#include "net/base/load_states.h"
 #include "net/base/request_priority.h"
+#include "net/base/upload_progress.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/http/http_transaction.h"
+#include "net/http/partial_data.h"
 #include "net/log/net_log.h"
 #include "net/socket/connection_attempts.h"
+#include "net/websockets/websocket_handshake_stream_base.h"
 
 namespace net {
 
+class IOBuffer;

[gavinp, 2015/06/17 13:56:14]

We use a scoped_refptr of IOBuffer (read_buf_ on line 462). That makes using a
forward declaration quite fragile; if any constructors or destructors are
generated then we could blow up. Should we just add an include?

(I didn't know this even worked! I spent some time playing with it to convince
myself that clang at least compiles scoped_refptr to a forward declared class,
although it is pretty easy to generate a method that blows it up...)

[Adam Rice, 2015/06/19 07:00:01]

No point in unnecessary excitement. I moved the io_buffer.h include to this
file.

 class PartialData;
 struct HttpRequestInfo;
 struct LoadTimingInfo;
 
 // This is the transaction that is returned by the HttpCache transaction
 // factory.
 class HttpCache::Transaction : public HttpTransaction {
  public:
   // The transaction has the following modes, which apply to how it may access
   // its cache entry.
@@ skipping 449 matching lines @@
   BeforeProxyHeadersSentCallback before_proxy_headers_sent_callback_;
 
   base::WeakPtrFactory<Transaction> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Transaction);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_CACHE_TRANSACTION_H_