Description[telemetry] Add support for BenchmarkResults that vary from page to page
This patch started out trying to add support for benchmarks that had different
outputs for each page. This is required for benchmarks that report [filtered]
profiling data, for instance something that simply groups timeline data and
reports it. To do csv output in taht situation, we have to hold output until
the end of the benchmark.
Making this work cleanly in the multi page benchmark code turned out to be
easily hacked, but unearthed a pretty hefty amount of deep, branchy code. So,
to make this cleaner, I cleaned up the results object.
We now have:
- PageBenchmarkResults: all results for the benchmark
- ValuesForSinglePage: all the results for a page
- PageBenchmarkValues: a single value from a benchmark
PerfBot benchmark output is managed by PageBenchmarkResults. Csv and Block
terminal-block was renamed to block, but with backcompat to terminal-block.
Nobody could remember terminal-block.
R=tonyg,hartmanng
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175602
Patch Set 1 #Patch Set 2 : bugfix #
Total comments: 1
Patch Set 3 : nitfix #Messages
Total messages: 5 (0 generated)
|