Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 11779041: [telemetry] Add support for BenchmarkResults that vary from page to page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nitfix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page_benchmark_value.py ('k') | tools/telemetry/telemetry/perf_tests_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page_runner.py
diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py
index 09508b7f06020f88d5d3fa1793e2c63b5686dc8a..ea2b984d85427d38fcb416ae4b1a3e49dcf844d3 100644
--- a/tools/telemetry/telemetry/page_runner.py
+++ b/tools/telemetry/telemetry/page_runner.py
@@ -95,8 +95,10 @@ http://goto/read-src-internal, or create a new archive using record_wpr.
# Check tracing directory.
if options.trace_dir:
+ if not os.path.exists(options.trace_dir):
+ os.mkdir(options.trace_dir)
if not os.path.isdir(options.trace_dir):
- raise Exception('Trace directory doesn\'t exist: %s' %
+ raise Exception('--trace-dir isn\'t a directory: %s' %
options.trace_dir)
elif os.listdir(options.trace_dir):
raise Exception('Trace directory isn\'t empty: %s' % options.trace_dir)
« no previous file with comments | « tools/telemetry/telemetry/page_benchmark_value.py ('k') | tools/telemetry/telemetry/perf_tests_helper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698