Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1177883003: Revert of Re-land: Enable external startup by default on Linux. (Closed)

Created:
5 years, 6 months ago by vogelheim
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Re-land: Enable external startup by default on Linux. (patchset #3 id:40001 of https://codereview.chromium.org/1041683002/) Reason for revert: Revert, due to problems with stale build artefacts uncovered by this. Details: https://code.google.com/p/v8/issues/detail?id=4171 Original issue's description: > Re-land: Enable external startup by default on Linux. > > crrev.com/1016603004 should have fixed the issues that broke this last time. > > Notes: > - The current functionality is meant to stay. If you prefer the old way, > just set v8_use_external_startup_data=0. > - You might notice this if you call d8 via PATH. Either explicitly tell d8 > where your external snapshot/built-ins are, or change the build options > as above. > - This follows Chromium practice, that mostly uses this feature these days. > - Other platforms to follow later. > > BUG= > > Committed: https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd > Cr-Commit-Position: refs/heads/master@{#28858} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1e49631ae612f18b48f2d91289754ba54531c6ef Cr-Commit-Position: refs/heads/master@{#28929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
Created Revert of Re-land: Enable external startup by default on Linux.
5 years, 6 months ago (2015-06-11 08:31:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177883003/1
5 years, 6 months ago (2015-06-11 08:32:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 08:32:26 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 08:32:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e49631ae612f18b48f2d91289754ba54531c6ef
Cr-Commit-Position: refs/heads/master@{#28929}

Powered by Google App Engine
This is Rietveld 408576698