Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1041683002: Re-land: Enable external startup by default on Linux. (Closed)

Created:
5 years, 9 months ago by vogelheim
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-land: Enable external startup by default on Linux. crrev.com/1016603004 should have fixed the issues that broke this last time. Notes: - The current functionality is meant to stay. If you prefer the old way, just set v8_use_external_startup_data=0. - You might notice this if you call d8 via PATH. Either explicitly tell d8 where your external snapshot/built-ins are, or change the build options as above. - This follows Chromium practice, that mostly uses this feature these days. - Other platforms to follow later. BUG= Committed: https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd Cr-Commit-Position: refs/heads/master@{#28858}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Don't enable for builds with different host/target toolsets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041683002/40001
5 years, 6 months ago (2015-06-09 09:53:49 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-09 09:53:50 UTC) #4
vogelheim
Commit-bot is right: I mentioned this in person, but forgot about actual review. :-| Care ...
5 years, 6 months ago (2015-06-09 09:56:40 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-09 09:57:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041683002/40001
5 years, 6 months ago (2015-06-09 09:58:21 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-09 09:59:27 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd Cr-Commit-Position: refs/heads/master@{#28858}
5 years, 6 months ago (2015-06-09 09:59:37 UTC) #11
vogelheim
5 years, 6 months ago (2015-06-11 08:31:54 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1177883003/ by vogelheim@chromium.org.

The reason for reverting is: Revert, due to problems with stale build artefacts
uncovered by this.

Details: https://code.google.com/p/v8/issues/detail?id=4171 .

Powered by Google App Engine
This is Rietveld 408576698