Issue 1177873003: Removes const qualification for two methods in TargetDataLowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177873003: Removes const qualification for two methods in TargetDataLowering. (Closed)

Created:
5 years, 6 months ago by John

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), Karl, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Removes const qualification for two methods in TargetDataLowering. Removes const qualifier for TargetDataLowering::lowerGlobals() and TargetDataLowering::lowerConstants() BUG= None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0f86d03ca2e44639ba03c659413f39eedcc75541

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -21 lines)			Patch
M	src/IceTargetLowering.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/IceTargetLoweringARM32.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/IceTargetLoweringARM32.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IceTargetLoweringX8632.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

John

5 years, 6 months ago (2015-06-15 14:44:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f86d03ca2e44639ba03c659413f39eedcc75541 (presubmit successful).