Chromium Code Reviews
Help | Chromium Project | Sign in
(65)

Issue 11778083: Test that 404 subresource bodies with nested message loops don't crash. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by gavinp
Modified:
1 year, 3 months ago
Reviewers:
sky
CC:
chromium-reviews_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Test that 404 subresource bodies with nested message loops don't crash.

This is a browser test because DumpRenderTree doesn't run nested message loops. The failure case was that a nested message triggered from an element that has signalled an error but had an open request would receive a body for the request and crash/fail an assertion.

This test checks the WebKit side fix for this issue, see https://bugs.webkit.org/show_bug.cgi?id=103563

R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Lint Patch
M content/browser/webkit_browsertest.cc View 1 chunk +15 lines, -0 lines 0 comments 0 errors Download
A content/test/data/error-body-no-crash.html View 1 chunk +6 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 11
gavinp
sky, What do you think?
1 year, 3 months ago #1
sky
Where is the nested message loop?
1 year, 3 months ago #2
gavinp
On 2013/01/10 16:30:34, sky wrote: > Where is the nested message loop? I have copied ...
1 year, 3 months ago #3
gavinp
And I engrammared the issue description, too.
1 year, 3 months ago #4
sky
LGTM
1 year, 3 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/11778083/1
1 year, 3 months ago #6
I haz the power (commit-bot)
Retried try job too often on linux_aura for step(s) content_browsertests
1 year, 3 months ago #7
gavinp
On 2013/01/14 16:17:25, I haz the power (commit-bot) wrote: > Retried try job too often ...
1 year, 3 months ago #8
gavinp
On 2013/01/14 16:52:50, gavinp wrote: > On 2013/01/14 16:17:25, I haz the power (commit-bot) wrote: ...
1 year, 3 months ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/11778083/1
1 year, 3 months ago #10
I haz the power (commit-bot)
1 year, 3 months ago #11
Message was sent while issue was closed.
Change committed as 176882
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6