Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/accessibility/browser_accessibility_state_impl.h

Issue 11778045: Add test for accessibility histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make UpdateHistograms private, add comment about content vs chrome Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_state_impl.h
diff --git a/content/browser/accessibility/browser_accessibility_state_impl.h b/content/browser/accessibility/browser_accessibility_state_impl.h
index 40d99fd409f24be80fd7ee7bb5aca25ae2dc143e..99a23178c940d39d5cbd490c9090654e847ec01f 100644
--- a/content/browser/accessibility/browser_accessibility_state_impl.h
+++ b/content/browser/accessibility/browser_accessibility_state_impl.h
@@ -45,9 +45,7 @@ class CONTENT_EXPORT BrowserAccessibilityStateImpl
virtual bool IsAccessibleBrowser() OVERRIDE;
virtual void AddHistogramCallback(base::Closure callback) OVERRIDE;
- // Called a short while after startup to allow time for the accessibility
- // state to be determined. Updates a histogram with the current state.
- void UpdateHistogram();
+ virtual void UpdateHistogramsForTesting() OVERRIDE;
AccessibilityMode GetAccessibilityMode();
void SetAccessibilityMode(AccessibilityMode mode);
@@ -56,6 +54,11 @@ class CONTENT_EXPORT BrowserAccessibilityStateImpl
friend class base::RefCountedThreadSafe<BrowserAccessibilityStateImpl>;
friend struct DefaultSingletonTraits<BrowserAccessibilityStateImpl>;
+ // Called a short while after startup to allow time for the accessibility
+ // state to be determined. Updates histograms with the current state.
+ // This method is public only for testing!
Jói 2013/01/08 23:14:14 You can remove this line now.
dmazzoni 2013/01/08 23:32:33 Done.
+ void UpdateHistograms();
+
// Leaky singleton, destructor generally won't be called.
virtual ~BrowserAccessibilityStateImpl();

Powered by Google App Engine
This is Rietveld 408576698