Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: content/browser/accessibility/browser_accessibility_state_impl.h

Issue 11778045: Add test for accessibility histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make UpdateHistograms private, add comment about content vs chrome Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_
6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_ 6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 27 matching lines...) Expand all
38 public: 38 public:
39 BrowserAccessibilityStateImpl(); 39 BrowserAccessibilityStateImpl();
40 40
41 static BrowserAccessibilityStateImpl* GetInstance(); 41 static BrowserAccessibilityStateImpl* GetInstance();
42 42
43 virtual void OnAccessibilityEnabledManually() OVERRIDE; 43 virtual void OnAccessibilityEnabledManually() OVERRIDE;
44 virtual void OnScreenReaderDetected() OVERRIDE; 44 virtual void OnScreenReaderDetected() OVERRIDE;
45 virtual bool IsAccessibleBrowser() OVERRIDE; 45 virtual bool IsAccessibleBrowser() OVERRIDE;
46 virtual void AddHistogramCallback(base::Closure callback) OVERRIDE; 46 virtual void AddHistogramCallback(base::Closure callback) OVERRIDE;
47 47
48 // Called a short while after startup to allow time for the accessibility 48 virtual void UpdateHistogramsForTesting() OVERRIDE;
49 // state to be determined. Updates a histogram with the current state.
50 void UpdateHistogram();
51 49
52 AccessibilityMode GetAccessibilityMode(); 50 AccessibilityMode GetAccessibilityMode();
53 void SetAccessibilityMode(AccessibilityMode mode); 51 void SetAccessibilityMode(AccessibilityMode mode);
54 52
55 private: 53 private:
56 friend class base::RefCountedThreadSafe<BrowserAccessibilityStateImpl>; 54 friend class base::RefCountedThreadSafe<BrowserAccessibilityStateImpl>;
57 friend struct DefaultSingletonTraits<BrowserAccessibilityStateImpl>; 55 friend struct DefaultSingletonTraits<BrowserAccessibilityStateImpl>;
58 56
57 // Called a short while after startup to allow time for the accessibility
58 // state to be determined. Updates histograms with the current state.
59 // This method is public only for testing!
Jói 2013/01/08 23:14:14 You can remove this line now.
dmazzoni 2013/01/08 23:32:33 Done.
60 void UpdateHistograms();
61
59 // Leaky singleton, destructor generally won't be called. 62 // Leaky singleton, destructor generally won't be called.
60 virtual ~BrowserAccessibilityStateImpl(); 63 virtual ~BrowserAccessibilityStateImpl();
61 64
62 void UpdatePlatformSpecificHistograms(); 65 void UpdatePlatformSpecificHistograms();
63 66
64 AccessibilityMode accessibility_mode_; 67 AccessibilityMode accessibility_mode_;
65 68
66 std::vector<base::Closure> histogram_callbacks_; 69 std::vector<base::Closure> histogram_callbacks_;
67 70
68 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityStateImpl); 71 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityStateImpl);
69 }; 72 };
70 73
71 } // namespace content 74 } // namespace content
72 75
73 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_ 76 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_STATE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698