Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 11778034: Revert 175489 (Closed)

Created:
7 years, 11 months ago by Dan Beam
Modified:
7 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, zork+watch_chromium.org, dmazzoni+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, yuzo+watch_chromium.org, ilevy+watch_chromium.org, joi+watch-content_chromium.org, android-webview-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, dtseng+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, ctguil+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert 175489 [javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:62: cannot find symbol [javac] symbol : method onEvaluateJavaScriptResult(int,java.lang.String) [javac] location: class org.chromium.content.browser.test.util.TestContentViewClient [javac] super.onEvaluateJavaScriptResult(id, jsonResult); [javac] ^ [javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:63: cannot find symbol [javac] symbol : method onEvaluateJavaScriptResult(int,java.lang.String) [javac] location: class org.chromium.content.browser.ContentViewClient [javac] mWrappedClient.onEvaluateJavaScriptResult(id, jsonResult); [javac] ^ [javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:60: method does not override or implement a method from a supertype [javac] @Override [javac] ^ [javac] 3 errors > Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult. > > BUG=168169 > TEST=should all pass > > > Review URL: https://chromiumcodereview.appspot.com/11788005 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -92 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java View 1 chunk +6 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
MM build/android/findbugs_filter/findbugs_exclude.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 5 chunks +36 lines, -37 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 1 chunk +8 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +9 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 4 chunks +10 lines, -15 lines 0 comments Download
MM content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 3 chunks +3 lines, -3 lines 0 comments Download
MM content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 5 chunks +20 lines, -19 lines 0 comments Download
MM content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years, 11 months ago (2013-01-08 06:19:09 UTC) #1
Avi (use Gerrit)
7 years, 11 months ago (2013-01-08 15:41:00 UTC) #2
Sigh. Yay trybots.


On Tue, Jan 8, 2013 at 1:19 AM, <dbeam@chromium.org> wrote:

> Reviewers: Avi,
>
> Description:
> Revert 175489
>
> [javac]
> /b/build/slave/Android_**Builder__dbg_/build/src/**
> content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**TestContentViewClientWrapper.**java:62:
> cannot find symbol
> [javac] symbol  : method onEvaluateJavaScriptResult(**
> int,java.lang.String)
> [javac] location: class
> org.chromium.content.browser.**test.util.**TestContentViewClient
> [javac]         super.**onEvaluateJavaScriptResult(id, jsonResult);
> [javac]              ^
> [javac]
> /b/build/slave/Android_**Builder__dbg_/build/src/**
> content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**TestContentViewClientWrapper.**java:63:
> cannot find symbol
> [javac] symbol  : method onEvaluateJavaScriptResult(**
> int,java.lang.String)
> [javac] location: class org.chromium.content.browser.**ContentViewClient
> [javac]         mWrappedClient.**onEvaluateJavaScriptResult(id,
> jsonResult);
> [javac]                       ^
> [javac]
> /b/build/slave/Android_**Builder__dbg_/build/src/**
> content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**TestContentViewClientWrapper.**java:60:
> method does not override or implement a method from a supertype
> [javac]     @Override
> [javac]     ^
> [javac] 3 errors
>
>  Switch Android code to use ExecuteJavascriptInWebFrameCal**lbackResult.
>>
>
>  BUG=168169
>> TEST=should all pass
>>
>
>
>  Review URL:
https://chromiumcodereview.**appspot.com/11788005<https://chromiumcodereview....
>>
>
> TBR=avi@chromium.org
>
> Please review this at
https://codereview.chromium.**org/11778034/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     android_webview/javatests/src/**org/chromium/android_webview/**
> test/TestAwContentsClient.java
>   M     android_webview/javatests/src/**org/chromium/android_webview/**
> test/util/JSUtils.java
>   MM    build/android/findbugs_filter/**findbugs_exclude.xml
>   M     content/browser/android/**content_view_core_impl.h
>   M     content/browser/android/**content_view_core_impl.cc
>   M     content/public/android/java/**src/org/chromium/content/**
> browser/ContentView.java
>   M     content/public/android/java/**src/org/chromium/content/**
> browser/ContentViewClient.java
>   M     content/public/android/java/**src/org/chromium/content/**
> browser/ContentViewCore.java
>   MM    content/public/android/java/**src/org/chromium/content/**
> browser/accessibility/**AccessibilityInjector.java
>   M     content/public/android/java/**src/org/chromium/content/**
> browser/accessibility/**JellyBeanAccessibilityInjector**.java
>   MM    content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**TestCallbackHelperContainer.**java
>   MM    content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**TestContentViewClient.java
>
>
>

Powered by Google App Engine
This is Rietveld 408576698