Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 11778034: Revert 175489 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java
===================================================================
--- content/public/android/java/src/org/chromium/content/browser/ContentView.java (revision 175490)
+++ content/public/android/java/src/org/chromium/content/browser/ContentView.java (working copy)
@@ -420,11 +420,17 @@
/**
* Injects the passed JavaScript code in the current page and evaluates it.
+ * Once evaluated, an asynchronous call to
+ * ContentViewClient.onJavaScriptEvaluationResult is made. Used in automation
+ * tests.
*
+ * @return an id that is passed along in the asynchronous onJavaScriptEvaluationResult callback
* @throws IllegalStateException If the ContentView has been destroyed.
+ *
+ * TODO(nileshagrawal): Remove this method from the public interface.
*/
- public void evaluateJavaScript(String script) throws IllegalStateException {
- mContentViewCore.evaluateJavaScript(script, null);
+ public int evaluateJavaScript(String script) throws IllegalStateException {
+ return mContentViewCore.evaluateJavaScript(script);
}
/**

Powered by Google App Engine
This is Rietveld 408576698