Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11778006: Don't run the "pkg" tests on the dart binary in the SDK. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 38dc33d047c052f7dd90d9be015141dc39bb6064..475a3589c8ae153ad655ae5dd3c4736910b01315 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -108,10 +108,10 @@ abstract class TestSuite {
* in the built SDK.
*/
bool get useSdk {
- // Some suites always use the SDK.
- // TODO(rnystrom): Eventually, all tests should run out of the SDK and this
- // check should go away.
- if (['pkg', 'pub'].contains(suiteName)) return true;
+ // The pub suite always uses the SDK.
+ // TODO(rnystrom): Eventually, all test suites should run out of the SDK
+ // and this check should go away.
+ if (suiteName == 'pub') return true;
return configuration['use_sdk'];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698