Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11778006: Don't run the "pkg" tests on the dart binary in the SDK. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 final Map configuration; 101 final Map configuration;
102 final String suiteName; 102 final String suiteName;
103 103
104 TestSuite(this.configuration, this.suiteName); 104 TestSuite(this.configuration, this.suiteName);
105 105
106 /** 106 /**
107 * Whether or not binaries should be found in the root build directory or 107 * Whether or not binaries should be found in the root build directory or
108 * in the built SDK. 108 * in the built SDK.
109 */ 109 */
110 bool get useSdk { 110 bool get useSdk {
111 // Some suites always use the SDK. 111 // The pub suite always uses the SDK.
112 // TODO(rnystrom): Eventually, all tests should run out of the SDK and this 112 // TODO(rnystrom): Eventually, all test suites should run out of the SDK
113 // check should go away. 113 // and this check should go away.
114 if (['pkg', 'pub'].contains(suiteName)) return true; 114 if (suiteName == 'pub') return true;
115 115
116 return configuration['use_sdk']; 116 return configuration['use_sdk'];
117 } 117 }
118 118
119 /** 119 /**
120 * The output directory for this suite's configuration. 120 * The output directory for this suite's configuration.
121 */ 121 */
122 String get buildDir => TestUtils.buildDir(configuration); 122 String get buildDir => TestUtils.buildDir(configuration);
123 123
124 /** 124 /**
(...skipping 1681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1806 * $pass tests are expected to pass 1806 * $pass tests are expected to pass
1807 * $failOk tests are expected to fail that we won't fix 1807 * $failOk tests are expected to fail that we won't fix
1808 * $fail tests are expected to fail that we should fix 1808 * $fail tests are expected to fail that we should fix
1809 * $crash tests are expected to crash that we should fix 1809 * $crash tests are expected to crash that we should fix
1810 * $timeout tests are allowed to timeout 1810 * $timeout tests are allowed to timeout
1811 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1811 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1812 """; 1812 """;
1813 print(report); 1813 print(report);
1814 } 1814 }
1815 } 1815 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698