Change DCHECK to DLOG_IF for non zero file watchers in FileBrowserEventRouter.

Change DCHECK to DLOG_IF for non zero file watchers in FileBrowserEventRouter.

The condition file_watchers_.empty() does not hold if user signed out
with Files.app opened (onunload looks intentionally suppressed
http://crbug.com/123107 in this case). So DCHECK is not appropriate.

That said, the check can be useful to detect possible future regressions
to forget unregistering the file watch. So keeping it as DLOG should be useful.

BUG=126275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175317

[kinaba, 2013-01-07 05:20:47]

ptal

[hashimoto, 2013-01-07 05:25:38]

lgtm

https://codereview.chromium.org/11776018/diff/2001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/11776018/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:113:
DLOG_IF(WARNING, !file_watchers_.empty()) << "Not all file watchers removed.";
nit: How about giving a more detailed comment like "Not all file watchers
removed. This can happen when Files.app is open during shutdown."?
I think it helps developers understand the situation in future.

[kinaba, 2013-01-07 05:51:49]

https://codereview.chromium.org/11776018/diff/2001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/11776018/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:113:
DLOG_IF(WARNING, !file_watchers_.empty()) << "Not all file watchers removed.";
On 2013/01/07 05:25:38, hashimoto wrote:
> nit: How about giving a more detailed comment like "Not all file watchers
> removed. This can happen when Files.app is open during shutdown."?
> I think it helps developers understand the situation in future.

Sounds good. Done.

[commit-bot: I haz the power, 2013-01-07 05:51:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/11776018/3017

[commit-bot: I haz the power, 2013-01-07 05:54:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/11776018/3017

[commit-bot: I haz the power, 2013-01-07 05:55:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/11776018/3017

[commit-bot: I haz the power, 2013-01-07 06:09:16]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests