Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_event_router.cc

Issue 11776018: Change DCHECK to DLOG_IF for non zero file watchers in FileBrowserEventRouter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More detailed message. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_browser_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_event_router.cc b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
index c861a9cdde7bc1bb718c44e6b7fde2e27efe9a61..4a5cce97c1e8058a635db7045772674ea53978f3 100644
--- a/chrome/browser/chromeos/extensions/file_browser_event_router.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
@@ -110,7 +110,8 @@ FileBrowserEventRouter::~FileBrowserEventRouter() {
void FileBrowserEventRouter::Shutdown() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK(file_watchers_.empty());
+ DLOG_IF(WARNING, !file_watchers_.empty()) << "Not all file watchers are "
+ << "removed. This can happen when Files.app is open during shutdown.";
STLDeleteValues(&file_watchers_);
if (!profile_) {
NOTREACHED();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698