Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 11776017: Enable readline on d8 while building a shared lib. (Closed)

Created:
7 years, 11 months ago by luismreis
Modified:
7 years, 11 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Enable readline on d8 while building a shared lib. This patch enables readline on d8 except for completion support. It sould be useful enough for history and line editing. This is related to V8's issue 1781 (http://code.google.com/p/v8/issues/detail?id=1781), not chromium's. BUG=v8:1781 Committed: https://code.google.com/p/v8/source/detail?r=13333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/d8.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/d8-readline.cc View 6 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
LGTM. Thanks for the contribution! I will land this for you.
7 years, 11 months ago (2013-01-08 15:23:04 UTC) #1
Jakob Kummerow
7 years, 11 months ago (2013-01-08 16:14:08 UTC) #2
Message was sent while issue was closed.
Hint: if you write BUG=v8:1781 in the CL description, that'll be linked
correctly to the V8 bug with that number.

Powered by Google App Engine
This is Rietveld 408576698